Fix json output when a node with attributes has the same key several times#245
Merged
omerbenamram merged 1 commit intoomerbenamram:masterfrom Nov 3, 2024
Merged
Fix json output when a node with attributes has the same key several times#245omerbenamram merged 1 commit intoomerbenamram:masterfrom
omerbenamram merged 1 commit intoomerbenamram:masterfrom
Conversation
fukusuket
added a commit
to Yamato-Security/hayabusa-evtx
that referenced
this pull request
Nov 4, 2024
…l times - omerbenamram/evtx#245 - Preserve order when using JSON output - omerbenamram/evtx#242
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some XML nodes have the same key multiple times. If the sub node have attributes, only the last key is keeped.
I adapted the code that managed nodes without attributes to manage those with.
The event "Microsoft-Windows-CertificateServicesClient-Lifecycle-System/Operational 1007" with the "EKU" node show the case.
Before the fix
{ [...] "UserData": { "CertNotificationData": { "#attributes": { "ProcessName": "PowerShell.exe", "AccountName": "LAB___\\Administrator", "Context": "Machine" }, "CertificateDetails": { "#attributes": { "Thumbprint": "a35fb0138078445b81b907997a719c2d55f070a8" }, "SubjectNames": { "SubjectName": "www.test.local", "SubjectName_1": "CN=test.local", "SubjectName_2": "test.local" }, "EKUs": { "EKU": { "#attributes": { "Name": "Server Authentication", "OID": "1.3.6.1.5.5.7.3.1" } } }, "NotValidAfter": "2025-09-23T13:23:57Z" } } } } }After the fix:
{ [...] "UserData": { "CertNotificationData": { "#attributes": { "ProcessName": "PowerShell.exe", "AccountName": "LAB___\\Administrator", "Context": "Machine" }, "CertificateDetails": { "#attributes": { "Thumbprint": "a35fb0138078445b81b907997a719c2d55f070a8" }, "SubjectNames": { "SubjectName": "www.test.local", "SubjectName_1": "CN=test.local", "SubjectName_2": "test.local" }, "EKUs": { "EKU": { "#attributes": { "Name": "Server Authentication", "OID": "1.3.6.1.5.5.7.3.1" } }, "EKU_1": { "#attributes": { "Name": "Client Authentication", "OID": "1.3.6.1.5.5.7.3.2" } } }, "NotValidAfter": "2025-09-23T13:23:57Z" } } } }